Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r98170182
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -336,14 +361,15 @@ class GeneralizedLinearRegression @Since("2.0.0")
(@Since("2.0.0") override val
}
val w = if (!isDefined(weightCol) || $(weightCol).isEmpty) lit(1.0)
else col($(weightCol))
- val instances: RDD[Instance] =
- dataset.select(col($(labelCol)), w, col($(featuresCol))).rdd.map {
- case Row(label: Double, weight: Double, features: Vector) =>
- Instance(label, weight, features)
- }
+ val off = if (!isDefined(offsetCol) || $(offsetCol).isEmpty) lit(0.0)
else col($(offsetCol))
--- End diff --
BTW, the new params like `offsetCol` should be added into
`Instrumentation.logParams` above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
