Github user lw-lin commented on the issue:
https://github.com/apache/spark/pull/16736
@gatorsmile fairly good point and thanks for the clarification!
- [Guava checks that maxSize >= 0 must
holds](https://github.com/google/guava/blob/v14.0.1/guava/src/com/google/common/cache/CacheBuilder.java#L407),
so surely it'd be best to report an error in our tone when maxSize is negative.
- [Guava states
that](https://github.com/google/guava/blob/v14.0.1/guava/src/com/google/common/cache/CacheBuilder.java#L392-L393):
`when size is zero, elements will be evicted immediately after being loaded
into the cache. This can be useful in testing, or to disable caching
temporarily without a code change.` So we'd expect all tests to pass, but let's
set maxSize to 0 and run all the test to verify it.
- As of case `1`, we'd expect that to work for all tests too, and I'll also
verify it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
