Github user steveloughran commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12004#discussion_r98448893
  
    --- Diff: 
cloud/src/test/scala/org/apache/spark/cloud/AzureInstantiationSuite.scala ---
    @@ -0,0 +1,29 @@
    +/*
    --- End diff --
    
    They don't detect much; they're just a simple sanity check of dependency 
pull in. Easy to pull; it just means that all tests will go downstream.
    
    My downstream tests [are more 
rigorous](https://github.com/steveloughran/spark-cloud-examples/blob/master/cloud-examples/src/test/scala/com/hortonworks/spark/cloud/s3/S3DependencyCheckSuite.scala)
 . and can also be executed under Jenkins without credentials, so there's 
nothing lost in cutting these, except that PRs to the scala project won't show 
up the problems directly


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to