Github user zhzhan commented on the pull request: https://github.com/apache/spark/pull/2241#issuecomment-55204266 Thanks for reviewing the code. Due to the special package requirements in hive-0.12.0 support, and some internal behavior change in hive 0.13, I have not found a good way to use reflection to dynamically support different hive versions. I agree with you the current patch may be invasive to the building changes for supporting different hive versions in the future. I have changed the profile to pick up the src directory automatically based on user specific versions, so that in the future, if new version is supported, there is no need to change the pom any more. In the meantime, it is possible in the future to support different hive versions with reflection. If that is the case, the current patch should be adapt to that approach. There are more development works required to be done on spark side to fully utilize hive-0.13 new features, and purpose of this patch is to give the customer a try and jumpstart the effort in the community. Please review the code and let me know your feedback.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org