Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/16537#discussion_r98955007
--- Diff: python/pyspark/sql/tests.py ---
@@ -429,6 +429,11 @@ def test_udf_with_input_file_name(self):
row =
self.spark.read.json(filePath).select(sourceFile(input_file_name())).first()
self.assertTrue(row[0].find("people1.json") != -1)
+ def test_udf_should_validate_input_args(self):
+ from pyspark.sql.functions import udf
+
+ self.assertRaises(TypeError, udf(lambda x: x), None)
--- End diff --
If this is covered by existing tests, then that's fine. Good point.
To validate number of args, I think it is a good idea, as long as we know
that it won't fail C extensions (but may be inconclusive).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
