Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/15435
@sethah
If I merge the MulticlassLogisticRegressionSummary into
LogisticRegressionSummary,
then, according to the hierarchy currently designed, it became:
class LogisticRegressionSummary extends MulticlassSummary with
LogisticRegressionSummary
class LogisticRegressionTrainingSummary extends LogisticRegressionSummary
with
** Note that now LogisticRegressionTrainingSummary must become a class, not
a trait, if merge the MulticlassLogisticRegressionSummary into
LogisticRegressionSummary, it has to be class...**
Now consider the `BinaryLogisticRegressionSummary`:
class BinaryLogisticRegressionSummary extends LogisticRegressionSummary
class BinaryLogisticRegressionTrainingSummary extends
BinaryLogisticRegressionSummary
** Now new problem occur: BinaryLogisticRegressionTrainingSummary cannot
extend LogisticRegressionTrainingSummary, because
`LogisticRegressionTrainingSummary` has changed into a class, not a trait... **
** BinaryLogisticRegressionTrainingSummary cannot extend
LogisticRegressionTrainingSummary cause more API breaking, such as `def
summary`...**
So these problems are troublesome... for causing so many API breaking...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
