Github user anabranch commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16138#discussion_r99278738
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
 ---
    @@ -1047,6 +1048,64 @@ case class ToDate(child: Expression) extends 
UnaryExpression with ImplicitCastIn
     }
     
     /**
    + * Parses a column to a date based on the given format.
    + */
    +// scalastyle:off line.size.limit
    +@ExpressionDescription(
    +  usage = "_FUNC_(date_str, fmt) - Parses the `left` expression with the 
`fmt` expression. Returns null with invalid input.",
    +  extended = """
    +    Examples:
    +      > SELECT _FUNC_('2016-12-31', 'yyyy-MM-dd');
    +       2016-12-31
    +  """)
    +// scalastyle:on line.size.limit
    +case class ParseToDate(left: Expression, format: Expression, child: 
Expression)
    --- End diff --
    
    I don't really understand this feedback. This is how I saw other 
`RuntimeReplaceable` expressions created.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to