GitHub user jinxing64 opened a pull request:
https://github.com/apache/spark/pull/16790
[SPARK-19450] Replace askWithRetry with askSync.
## What changes were proposed in this pull request?
`askSync` is already added in `RpcEndpointRef` (see SPARK-19347 and
https://github.com/apache/spark/pull/16690#issuecomment-276850068) and
`askWithRetry` is marked as deprecated.
As mentioned
SPARK-18113(https://github.com/apache/spark/pull/16503#event-927953218):
>askWithRetry is basically an unneeded API, and a leftover from the akka
days that doesn't make sense anymore. It's prone to cause deadlocks (exactly
because it's blocking), it imposes restrictions on the caller (e.g.
idempotency) and other things that people generally don't pay that much
attention to when using it.
Since `askWithRetry` is just used inside spark and not in user logic. It
might make sense to replace all of them with `askSync`.
## How was this patch tested?
This PR doesn't change code logic, existing unit test can cover.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jinxing64/spark SPARK-19450
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/16790.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16790
----
commit b575c55ed9901b4dcf5b3e977a55f135b02aa4b1
Author: jinxing <jinx...@meituan.com>
Date: 2017-02-03T17:29:05Z
[SPARK-19450] Replace askWithRetry with askSync.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
