Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16269#discussion_r99394101
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -405,32 +405,4 @@ abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
case _ => Nil
}
}
-
- object DDLStrategy extends Strategy {
- def apply(plan: LogicalPlan): Seq[SparkPlan] = plan match {
- case CreateTable(tableDesc, mode, None) if
DDLUtils.isHiveTable(tableDesc) =>
- val cmd = CreateTableCommand(tableDesc, ifNotExists = mode ==
SaveMode.Ignore)
- ExecutedCommandExec(cmd) :: Nil
-
- case CreateTable(tableDesc, mode, None) =>
- val cmd =
- CreateDataSourceTableCommand(tableDesc, ignoreIfExists = mode ==
SaveMode.Ignore)
- ExecutedCommandExec(cmd) :: Nil
-
- // CREATE TABLE ... AS SELECT ... for hive serde table is handled in
hive module, by rule
- // `CreateTables`
-
- case CreateTable(tableDesc, mode, Some(query)) if
DDLUtils.isDatasourceTable(tableDesc) =>
- val cmd =
- CreateDataSourceTableAsSelectCommand(
- tableDesc,
- mode,
- query)
- ExecutedCommandExec(cmd) :: Nil
--- End diff --
To other reviewers: the above two are moved to `DataSourceAnalysis`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
