Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16740#discussion_r99407439
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -335,6 +335,11 @@ class GeneralizedLinearRegression @Since("2.0.0")
(@Since("2.0.0") override val
throw new SparkException(msg)
}
+ if (numFeatures == 0 && !$(fitIntercept)) {
+ val msg = "Specified model is empty with neither intercept nor
feature."
+ throw new SparkException(msg)
--- End diff --
I think `require`, which throws `IllegalArgumentException` is more
appropriate here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
