Github user salilsurendran commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99414739
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -428,8 +481,14 @@ final class DataFrameWriter[T] private[sql](ds:
Dataset[T]) {
partitionColumnNames = partitioningColumns.getOrElse(Nil),
bucketSpec = getBucketSpec
)
- df.sparkSession.sessionState.executePlan(
- CreateTable(tableDesc, mode, Some(df.logicalPlan))).toRdd
+ val qe = df.sparkSession.sessionState.executePlan(
+ CreateTable(tableDesc, mode, Some(df.logicalPlan)))
+ executeAndCallQEListener(
+ "saveAsTable",
+ qe,
+ new OutputParams(source, Some(tableIdent.unquotedString),
extraOptions.toMap)) {
--- End diff --
source reflects the Datasource type to which the data is written. So in
case of the parquet(), csv() methods it will be "parquet" and "csv". So in case
of saveAsTable() should it be "hive" or "db" since qualified table name is not
actually a datasource type?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
