Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16787#discussion_r99460070
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala 
---
    @@ -365,8 +365,8 @@ private[hive] class HiveClientImpl(
         Option(client.getTable(dbName, tableName, false)).map { h =>
           // Note: Hive separates partition columns and the schema, but for us 
the
           // partition columns are part of the schema
    -      val partCols = h.getPartCols.asScala.map(fromHiveColumn)
    -      val schema = StructType(h.getCols.asScala.map(fromHiveColumn) ++ 
partCols)
    +      val partCols = 
h.getPartCols.asScala.map(HiveClientImpl.fromHiveColumn)
    +      val schema = 
StructType(h.getCols.asScala.map(HiveClientImpl.fromHiveColumn) ++ partCols)
    --- End diff --
    
    This will use `HiveUtils.hiveExecutionVersion`. However, it should use the 
version `spark.sql.hive.metastore.version`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to