Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16803#discussion_r99518229
  
    --- Diff: 
core/src/test/scala/org/apache/spark/deploy/SparkSubmitUtilsSuite.scala ---
    @@ -258,4 +259,53 @@ class SparkSubmitUtilsSuite extends SparkFunSuite with 
BeforeAndAfterAll {
           assert(jarPath.indexOf("mydep") >= 0, "should find dependency")
         }
       }
    +
    +  test("search for artifact taking order from user defined repositories to 
default repositories") {
    +    val main = new MavenCoordinate("a", "b", "0.1")
    +
    +    def isSameFile(left: String, right: String): Boolean = {
    +      val leftInput: FileInputStream = new FileInputStream(left)
    +      val leftMd5 = UTF8String.fromString(org.apache.commons.codec
    --- End diff --
    
    why convert it to `UTF8String` and compare?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to