Github user pfcoperez commented on the issue:

    https://github.com/apache/spark/pull/16823
  
    @andrewor14 @srowen In any case, I just wanted to add that copying code is, 
basically the worst strategy. 
    
    If you wanted to constraint the types for those tree and not just 
**AnyVal** sub-classes I would recommend doing something as:
    
    ```
    def config(key: String, value: Double): Builder = config(key, 
value.toString)
    def config(key: String, value: Boolean): Builder = config(key, 
value.toString)
    def config(key: String, value: Long): Builder = config(key, value.toString) 
        
    ```
    
    Exactly same interface, no copy-paste code. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to