Github user jsoltren commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16650#discussion_r99660755
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
 ---
    @@ -600,6 +603,16 @@ class CoarseGrainedSchedulerBackend(scheduler: 
TaskSchedulerImpl, val rpcEnv: Rp
        */
       protected def doKillExecutors(executorIds: Seq[String]): Future[Boolean] 
=
         Future.successful(false)
    +
    +  /**
    +   * Request that the cluster manager kill all executors on a given host.
    +   * @return whether the kill request is acknowledged.
    +   */
    +  final override def killExecutorsOnHost(host: String): Boolean = {
    +    logInfo(s"Requesting to kill any and all executors on host ${host}")
    +    driverEndpoint.send(KillExecutorsOnHost(host))
    --- End diff --
    
    Sure. I've paraphrased this a bit but it's a helpful comment to add.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to