Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16828#discussion_r99836122 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -832,7 +832,13 @@ private[hive] class HiveClientImpl( val (partCols, schema) = table.schema.map(toHiveColumn).partition { c => table.partitionColumnNames.contains(c.getName) } - if (schema.isEmpty) { + + // after SPARK-19279, it is not allowed to create a table with an empty schema, but we should + // support it when test some HiveExternalCatalog BackwardCompatibility cases to create an old + // spark table. the SPARK_TEST_OLD_SOURCE_TABLE_CREATE property is used to resolve this. + if (schema.isEmpty && (table.properties.getOrElse( + HiveExternalCatalog.DATASOURCE_SCHEMA_NUMPARTS, "0").toInt != 0) || table.properties + .getOrElse(HiveExternalCatalog.SPARK_TEST_OLD_SOURCE_TABLE_CREATE, "false").toBoolean) { --- End diff -- when will we hit this branch? only when we create empty schema table in test?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org