Github user budde commented on a diff in the pull request:
https://github.com/apache/spark/pull/16744#discussion_r99905577
--- Diff:
external/kinesis-asl/src/test/scala/org/apache/spark/streaming/kinesis/KinesisReceiverSuite.scala
---
@@ -62,9 +62,20 @@ class KinesisReceiverSuite extends TestSuiteBase with
Matchers with BeforeAndAft
checkpointerMock = mock[IRecordProcessorCheckpointer]
}
- test("check serializability of SerializableAWSCredentials") {
- Utils.deserialize[SerializableAWSCredentials](
- Utils.serialize(new SerializableAWSCredentials("x", "y")))
+ test("check serializability of credential provider classes") {
+ Utils.deserialize[BasicCredentialsProvider](
+ Utils.serialize(BasicCredentialsProvider(
+ awsAccessKeyId = "x",
+ awsSecretKey = "y")))
+
+ Utils.deserialize[STSCredentialsProvider](
+ Utils.serialize(STSCredentialsProvider(
+ stsRoleArn = "fakeArn",
+ stsSessionName = "fakeSessionName",
+ stsExternalId = Some("fakeExternalId"),
+ longLivedCredsProvider = BasicCredentialsProvider(
--- End diff --
I'll add another test ```longLivedCredentialsProvider.``` I ran into errors
making similar ser/de test for ```DefaultCredentialsProvider``` since it's a
case class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
