Github user jaceklaskowski commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16812#discussion_r99935530
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
 ---
    @@ -139,6 +140,20 @@ class CSVSuite extends QueryTest with SharedSQLContext 
with SQLTestUtils {
         assert(result.schema === expectedSchema)
       }
     
    +  test("test inferring booleans with custom values") {
    +    val result = spark.read
    +      .format("csv")
    +      .option("header", "true")
    --- End diff --
    
    Could you use `true` (boolean literal) instead to promote the more 
type-safe approach?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to