GitHub user sureshthalamati opened a pull request:

    https://github.com/apache/spark/pull/16847

    [SPARK-19318][SQL] Fix to send JDBC connection properties to the source as 
user-specified (case-sensitive)

    ## What changes were proposed in this pull request?
    The reason for test failure is that the  property 
“oracle.jdbc.mapDateToTimestamp” set by the test was getting converted into 
all lower case.  Oracle database expects this property in case-sensitive 
manner. 
    
    This test was passing in previous releases because connection properties 
were sent as user specified for the test case scenario. Fixes to handle all 
option uniformly in case-insensitive manner, converted the JDBC connection 
properties also to lower case.
    
    This PR makes changes to treat only JDBC options meant for spark sql in 
case-insensitive manner , and pass the connection properties to the JDBC  
connection.as user specified.
    
    ## How was this patch tested?
    Added new test cases to JdbcSuite , and OracleIntegrationSuite.  Ran docker 
integration tests passed on my laptop, all tests passed successfully.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sureshthalamati/spark 
jdbc_connection_props_fix-SPARK-19318

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/16847.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #16847
    
----
commit 81e906052ea766fe4f228b84db5caea22860dae4
Author: sureshthalamati <suresh.thalam...@gmail.com>
Date:   2017-02-07T21:02:20Z

    [SPARK-19318][SQL] JDBC connection properties specifed by the user are 
treated in case-sensitive manner

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to