Github user mhmoudr commented on the issue:
https://github.com/apache/spark/pull/16495
Sure .. I am, but just a bit busy nowadays, in general I am planing to
investigate the additional complexity issue, and as for the test I agree with
the fact that the test should not be added to unit test as far as there is a
specific agreed manner for adding stress tests, also to add, in term of the
test itself, I would say it will be a wast of time to train the model every
time we need to test this area, so I was thinking of train a model once and
save it to resources, then once I need to test the evaluateEachIteration it
will be much faster to lead the pre saved model from resources and run the test
directly, thoughts?
for the time being I will close the pull request and once I have the change
ready I will create a new one.
Mahmoud
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
