GitHub user bogdanrdc opened a pull request:

    https://github.com/apache/spark/pull/16852

    [SPARK-19512][SQL] codegen for compare structs fails

    ## What changes were proposed in this pull request?
    
    Set currentVars to null in GenerateOrdering.genComparisons before genCode 
is called. genCode ignores INPUT_ROW if currentVars is not null and in 
genComparisons we want it to use INPUT_ROW.
    
    ## How was this patch tested?
    
    Added test with 2 queries in WholeStageCodegenSuite


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bogdanrdc/spark SPARK-19512

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/16852.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #16852
    
----
commit 484c9d6a86015d78b20b142adbf77faab27bbe49
Author: Bogdan Raducanu <bogdan....@gmail.com>
Date:   2017-02-08T11:51:42Z

    fix in GenerateOrdering + tests

commit 9a8d8537748f38a4276188b3f60f6852010e3387
Author: Bogdan Raducanu <bogdan....@gmail.com>
Date:   2017-02-08T11:55:32Z

    test rename

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to