Github user NathanHowell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100100641
--- Diff:
core/src/main/scala/org/apache/spark/input/PortableDataStream.scala ---
@@ -194,5 +195,8 @@ class PortableDataStream(
}
def getPath(): String = path
+
+ @Since("2.2.0")
--- End diff --
This is a public class so I thought adding a `since` tag would benefit the
documentation. If it's not desired I can certainly remove it.
As for making the lazy val public vs private: I'm following the style used
already in the class. There are public get methods for each private field. I'm
not partial to either approach but prefer to keep it consistent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
