Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/16859#discussion_r100159293 --- Diff: common/network-common/src/main/java/org/apache/spark/network/server/TransportChannelHandler.java --- @@ -48,7 +47,7 @@ * on the channel for at least `requestTimeoutMs`. Note that this is duplex traffic; we will not * timeout if the client is continuously sending but getting no responses, for simplicity. */ -public class TransportChannelHandler extends SimpleChannelInboundHandler<Message> { +public class TransportChannelHandler extends ChannelInboundHandlerAdapter { --- End diff -- SimpleChannelInboundHandler also uses Javassist to generate a matcher class. Since `SimpleChannelInboundHandler` provides little value for us, I just changed to extend `ChannelInboundHandlerAdapter` directly.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org