Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16855#discussion_r100187114
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -874,7 +874,8 @@ private[spark] class TaskSetManager(
// and we are not using an external shuffle server which could serve
the shuffle outputs.
// The reason is the next stage wouldn't be able to fetch the data
from this dead executor
// so we would need to rerun these tasks on other executors.
- if (tasks(0).isInstanceOf[ShuffleMapTask] &&
!env.blockManager.externalShuffleServiceEnabled) {
+ if (tasks(0).isInstanceOf[ShuffleMapTask] &&
!env.blockManager.externalShuffleServiceEnabled
+ && !isZombie) {
--- End diff --
Also I'm concerned that we might need some of the functionality below even
when the TSM is a zombie. While the TSM shouldn't tell the DAGScheduler that
the task was resubmitted, I think it does need to notify the DAGScheduler that
tasks on the executor are finished (otherwise they'll never be marked as
finished in the UI, for example), and I also think it needs to properly update
the running copies of the task.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
