Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/16826#discussion_r100194351
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SessionState.scala ---
@@ -65,12 +80,29 @@ private[sql] class SessionState(sparkSession:
SparkSession) {
hadoopConf
}
- lazy val experimentalMethods = new ExperimentalMethods
+ lazy val experimentalMethods: ExperimentalMethods = {
+ existingSessionState
+ .map(_.experimentalMethods.clone)
+ .getOrElse(new ExperimentalMethods)
+ }
/**
* Internal catalog for managing functions registered by the user.
*/
- lazy val functionRegistry: FunctionRegistry =
FunctionRegistry.builtin.copy()
+ lazy val functionRegistry: FunctionRegistry = {
--- End diff --
It's better to just add a `copy` method to `FunctionRegistry` to simplify
these codes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
