Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16868#discussion_r100255988
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -833,54 +833,107 @@ class HiveDDLSuite
}
test("CREATE TABLE LIKE a temporary view") {
+ // CREATE TABLE LIKE a temporary view.
+ withCreateTableLikeTempView(None)
+
+ // CREATE TABLE LIKE a temporary view location ...
+ withTempDir {tmpDir =>
+ withCreateTableLikeTempView(Some(tmpDir.getPath))
+ }
+ }
+
+ private def withCreateTableLikeTempView(location : Option[String]): Unit
= {
val sourceViewName = "tab1"
val targetTabName = "tab2"
+ var createdTableType = CatalogTableType.MANAGED
--- End diff --
we can make it more explicitly:
```
val tableType = if (location.isDefiend) EXTERNAL else MANAGED
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
