Github user Bcpoole commented on a diff in the pull request:
https://github.com/apache/spark/pull/16864#discussion_r100385258
--- Diff:
common/sketch/src/main/java/org/apache/spark/util/sketch/BloomFilter.java ---
@@ -81,6 +81,11 @@ int getVersionNumber() {
public abstract long bitSize();
/**
+ * Swamidass & Baldi (2007) approximation for number of items in a Bloom
filter
+ */
+ public abstract double approxItems();
--- End diff --
I was debating this due to possible rounding errors.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
