Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r100486268
--- Diff:
graphx/src/main/scala/org/apache/spark/graphx/util/PeriodicGraphCheckpointer.scala
---
@@ -87,10 +88,7 @@ private[mllib] class PeriodicGraphCheckpointer[VD, ED](
override protected def persist(data: Graph[VD, ED]): Unit = {
if (data.vertices.getStorageLevel == StorageLevel.NONE) {
- data.vertices.persist()
- }
- if (data.edges.getStorageLevel == StorageLevel.NONE) {
- data.edges.persist()
+ data.persist()
--- End diff --
hmm, `GraphImpl.persist` actually persists its `vertices` and
`replicatedVertexView.edges` (i.e., `edges`). But the problem is we only check
the storage level of vertices. Maybe we should keep the original.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
