Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100649748
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonFileFormat.scala
---
@@ -97,46 +91,13 @@ class JsonFileFormat extends TextBasedFileFormat with
DataSourceRegister {
val broadcastedHadoopConf =
sparkSession.sparkContext.broadcast(new
SerializableConfiguration(hadoopConf))
- val parsedOptions: JSONOptions = new JSONOptions(options)
- val columnNameOfCorruptRecord = parsedOptions.columnNameOfCorruptRecord
- .getOrElse(sparkSession.sessionState.conf.columnNameOfCorruptRecord)
+ val parsedOptions = new JSONOptions(options,
+ sparkSession.sessionState.conf.columnNameOfCorruptRecord)
+ val readFile = JsonDataSource(parsedOptions).readFile _
--- End diff --
this closure has the reference of the outer pointer, so we will still
broadcast the `JsonDataSource`. how about
```
val columnNameOfCorruptRecord =
sparkSession.sessionState.conf.columnNameOfCorruptRecord)
(file: PartitionedFile) => {
val parsedOptions =...
val parser = new JacksonParser(requiredSchema, parsedOptions)
JsonDataSource(parsedOptions).readFile...
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
