Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16854#discussion_r100667530
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
@@ -361,6 +362,41 @@ class DataFrameReader private[sql](sparkSession:
SparkSession) extends Logging {
}
/**
+ * Loads an `Dataset[String]` storing CSV rows and returns the result as
a `DataFrame`.
+ *
+ * Unless the schema is specified using `schema` function, this function
goes through the
+ * input once to determine the input schema.
+ *
+ * @param csvDataset input Dataset with one CSV row per record
+ * @since 2.2.0
+ */
+ def csv(csvDataset: Dataset[String]): DataFrame = {
--- End diff --
Sure. Actually, there is a JIRA and closed PR
https://github.com/apache/spark/pull/13460 and
[SPARK-15615](https://issues.apache.org/jira/browse/SPARK-15615) where I was
negative because it can be easily worked around.
However, I am fine if we are promoting to use datasets instead of RDDs for
some advantages such as
[SPARK-18362](https://issues.apache.org/jira/browse/SPARK-18362).
cc @pjfanning, could you reopen and proceed your PR if we are all fine?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
