Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16787#discussion_r100681187
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
    @@ -649,6 +648,16 @@ class VersionsSuite extends QueryTest with 
SQLTestUtils with TestHiveSingleton w
           }
         }
     
    +    test(s"$version: create table should success to test 
HiveClientImpl.toHiveTable compatible") {
    +      withTable("t", "t1") {
    +        import spark.implicits._
    +        Seq("1").toDF("a").write.saveAsTable("t")
    +        checkAnswer(spark.table("t"), Row("1") :: Nil)
    +
    +        spark.sql("create table t1 as select 2 as a")
    +        checkAnswer(spark.table("t1"), Row(2) :: Nil)
    --- End diff --
    
    Table `t` and `t1` are managed tables. Could you also verify whether the 
location are expected?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to