Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16878#discussion_r100682360
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -425,7 +425,9 @@ class SparkSqlAstBuilder(conf: SQLConf) extends
AstBuilder {
logWarning(s"CREATE TEMPORARY TABLE ... USING ... is deprecated,
please use " +
"CREATE TEMPORARY VIEW ... USING ... instead")
- CreateTempViewUsing(table, schema, replace = true, global = false,
provider, options)
+ // Since we don't support IF NOT EXISTS for temp table, we should
not allow
+ // replacing existing temp table, that may accidentally remove a
temp view in use.
--- End diff --
Just got your points... How about update the description to
```
Unlike CREATE TEMPORARY VIEW USING, CREATE TEMPORARY TABLE USING does not
support IF NOT EXISTS, we should not allow users replacing the existing temp
table; otherwise, it may accidentally remove a temp view in use.
```
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
