Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2341#discussion_r17466108
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala ---
@@ -435,18 +385,18 @@ object DecisionTree extends Serializable with Logging
{
// numGroups is equal to 2 at level 11 and 4 at level 12,
respectively.
val numGroups = 1 << level - maxLevelForSingleGroup
logDebug("numGroups = " + numGroups)
- var bestSplits = new Array[(Split, InformationGainStats, Predict)](0)
// Iterate over each group of nodes at a level.
var groupIndex = 0
+ var doneTraining = true
while (groupIndex < numGroups) {
- val bestSplitsForGroup = findBestSplitsPerGroup(input,
parentImpurities, metadata, level,
- nodes, splits, bins, timer, numGroups, groupIndex)
- bestSplits = Array.concat(bestSplits, bestSplitsForGroup)
+ val (tmpRoot, doneTrainingGroup) = findBestSplitsPerGroup(input,
metadata, level,
--- End diff --
`tmpRoot` -> `_` (since it is not used after)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
