Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/16925#discussion_r101129302 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala --- @@ -493,4 +493,46 @@ class PlanParserSuite extends PlanTest { assertEqual("select a, b from db.c where x !> 1", table("db", "c").where('x <= 1).select('a, 'b)) } + + test("select hint syntax") { + // Hive compatibility: Missing parameter raises ParseException. + val m = intercept[ParseException] { + parsePlan("SELECT /*+ HINT() */ * FROM t") + }.getMessage + assert(m.contains("no viable alternative at input")) + + // Hive compatibility: No database. + val m2 = intercept[ParseException] { + parsePlan("SELECT /*+ MAPJOIN(default.t) */ * from default.t") + }.getMessage + assert(m2.contains("no viable alternative at input")) + + comparePlans( + parsePlan("SELECT /*+ HINT */ * FROM t"), + Hint("HINT", Seq.empty, table("t").select(star()))) + + comparePlans( + parsePlan("SELECT /*+ BROADCASTJOIN(u) */ * FROM t"), + Hint("BROADCASTJOIN", Seq("u"), table("t").select(star()))) + + comparePlans( + parsePlan("SELECT /*+ MAPJOIN(u) */ * FROM t"), + Hint("MAPJOIN", Seq("u"), table("t").select(star()))) + + comparePlans( + parsePlan("SELECT /*+ STREAMTABLE(a,b,c) */ * FROM t"), + Hint("STREAMTABLE", Seq("a", "b", "c"), table("t").select(star()))) + + comparePlans( + parsePlan("SELECT /*+ INDEX(t emp_job_ix) */ * FROM t"), --- End diff -- Yes. Both are considered equally now.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org