Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16630#discussion_r101220572 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala --- @@ -915,6 +917,22 @@ class GeneralizedLinearRegressionSummary private[regression] ( /** Number of instances in DataFrame predictions. */ private[regression] lazy val numInstances: Long = predictions.count() + + /** + * Name of features. If the name cannot be retrieved from attributes, + * set default names to "V1", "V2", and so on. + */ + @Since("2.2.0") + lazy val featureName: Array[String] = { + val featureAttrs = AttributeGroup.fromStructField( + dataset.schema(model.getFeaturesCol)).attributes + if (featureAttrs == None) { + Array.tabulate[String](origModel.numFeatures)((x: Int) => ("V" + (x + 1))) --- End diff -- quite possibly - could you check what would be new or removed with that approach?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org