Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16931#discussion_r101338203
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/sources/BucketedWriteSuite.scala 
---
    @@ -169,19 +169,20 @@ class BucketedWriteSuite extends QueryTest with 
SQLTestUtils with TestHiveSingle
         }
       }
     
    -  test("write bucketed data with the overlapping bucketBy and partitionBy 
columns") {
    -    intercept[AnalysisException](df.write
    +  test("write bucketed data with the overlapping bucketBy/sortBy and 
partitionBy columns") {
    --- End diff --
    
    Not related to this PR, but I think we should move most test cases to sql 
packages. Let me try to do it. Only orc formats are hive only. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to