Github user erenavsarogullari commented on the issue:

    https://github.com/apache/spark/pull/16905
  
    Hi All,
    All comments are addressed and this is ready for re-review.
    
    @markhamstra, if it is suitable, i plan to address _removing 
SchedulingMode.NONE_ via separated PR. In the light of this, the following 
**new added** unit test cases(using `NONE`) can be removed from this PR:
    - `PoolSuite`: Pool should throw IllegalArgumentException when 
schedulingMode is not supported
    - `TaskSchedulerImplSuite`: TaskScheduler should throw 
IllegalArgumentException when schedulingMode is not supported
    
    WDYT?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to