Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14412#discussion_r101447299
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -1131,14 +1131,43 @@ private[spark] class BlockManager(
}
/**
+ * Called for pro-active replenishment of blocks lost due to executor
failures
+ *
+ * @param blockId blockId being replicate
+ * @param existingReplicas existing block managers that have a replica
+ * @param maxReplicas maximum replicas needed
+ * @return
+ */
+ def replicateBlock(
+ blockId: BlockId,
+ existingReplicas: Set[BlockManagerId],
+ maxReplicas: Int): Unit = {
+ logInfo(s"Pro-actively replicating $blockId")
+ val infoForReplication = blockInfoManager.lockForReading(blockId).map
{ info =>
--- End diff --
This call acquires a read lock on the block, but when is that lock
released? Per the Scaladoc of `doGetLocalBytes`, you need to be holding a read
lock before calling that method, but upon successful return from that method
the read lock will still be held by the caller.
I think what you want to do is acquire the lock, immediately call
`doGetLocalBytes`, then begin a `try-finally` statement to call `replicate()`
and unlock / release the lock in the `finally` block.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
