Github user pjfanning commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16895#discussion_r101460138
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
 ---
    @@ -1364,10 +1364,11 @@ class JsonSuite extends QueryTest with 
SharedSQLContext with TestJsonData {
         })
       }
     
    -  test("SPARK-6245 JsonRDD.inferSchema on empty RDD") {
    +  test("SPARK-6245 JsonRDD.inferSchema on empty Dataset") {
         // This is really a test that it doesn't throw an exception
    +    val emptyDataset = spark.createDataset(empty)(Encoders.STRING)
    --- End diff --
    
    RDD[_] only has toDS() function added when SQLImplicits applies an implicit 
conversion to wrap the RDD as a DatasetHolder.
    import sparkSession.sqlContext.implicits._



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to