Github user dosoft commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16924#discussion_r101487342
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
    @@ -137,7 +138,13 @@ private[spark] class EventLoggingListener(
         // scalastyle:on println
         if (flushLogger) {
           writer.foreach(_.flush())
    -      hadoopDataStream.foreach(_.hflush())
    +      hadoopDataStream.foreach(ds => {
    --- End diff --
    
    hsync() is even stronger than hflush(), since under the cover both methods 
use the same flushOrSync(), but hsync performs an additional tasks like 
flushing OS buffers (fsync).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to