Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16499#discussion_r101674560
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -1018,7 +1025,9 @@ private[spark] class BlockManager(
try {
replicate(blockId, bytesToReplicate, level, remoteClassTag)
} finally {
- bytesToReplicate.dispose()
+ if (!level.useOffHeap) {
--- End diff --
Similarly, aren't we deciding whether we should dispose `bytesToReplicate`
based on the 'target' `StorageLevel`? Shouldn't we make that decision based on
whether `bytesToReplicate` were stored off-heap or not?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
