Github user brkyvz commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r101824321
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala
---
@@ -35,6 +35,9 @@ object UnsupportedOperationChecker {
case p if p.isStreaming =>
throwError("Queries with streaming sources must be executed with
writeStream.start()")(p)
+ case p: Deduplication =>
+ throwError("Batch queries should not use Deduplication")(p)
--- End diff --
because of this, I would prefer the naming to imply that as well. Maybe
rename `Deduplication` to `StreamingDeduplication` or something.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
