Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r101878004
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/DeduplicationSuite.scala
---
@@ -0,0 +1,235 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.streaming
+
+import org.scalatest.BeforeAndAfterAll
+
+import org.apache.spark.sql.catalyst.streaming.InternalOutputModes._
+import org.apache.spark.sql.execution.streaming.MemoryStream
+import org.apache.spark.sql.execution.streaming.state.StateStore
+import org.apache.spark.sql.functions._
+
+class DeduplicationSuite extends StreamTest with BeforeAndAfterAll {
+
+ import testImplicits._
+
+ override def afterAll(): Unit = {
+ super.afterAll()
+ StateStore.stop()
+ }
+
+ test("deduplication") {
+ val inputData = MemoryStream[String]
+ val result = inputData.toDS().dropDuplicates()
+
+ testStream(result, Append)(
+ AddData(inputData, "a"),
+ CheckLastBatch("a"),
+ assertNumStateRows(total = 1, updated = 1),
+ AddData(inputData, "a"),
+ CheckLastBatch(),
+ assertNumStateRows(total = 1, updated = 0),
+ AddData(inputData, "b"),
+ CheckLastBatch("b"),
+ assertNumStateRows(total = 2, updated = 1)
+ )
+ }
+
+ test("deduplication with columns") {
+ val inputData = MemoryStream[(String, Int)]
+ val result = inputData.toDS().dropDuplicates("_1")
+
+ testStream(result, Append)(
+ AddData(inputData, "a" -> 1),
+ CheckLastBatch("a" -> 1),
+ assertNumStateRows(total = 1, updated = 1),
+ AddData(inputData, "a" -> 2), // Dropped
+ CheckLastBatch(),
+ assertNumStateRows(total = 1, updated = 0),
+ AddData(inputData, "b" -> 1),
+ CheckLastBatch("b" -> 1),
+ assertNumStateRows(total = 2, updated = 1)
+ )
+ }
+
+ test("multiple deduplications") {
+ val inputData = MemoryStream[(String, Int)]
+ val result = inputData.toDS().dropDuplicates().dropDuplicates("_1")
+
+ testStream(result, Append)(
+ AddData(inputData, "a" -> 1),
+ CheckLastBatch("a" -> 1),
+ assertNumStateRows(total = Seq(1L, 1L), updated = Seq(1L, 1L)),
+
+ AddData(inputData, "a" -> 2), // Dropped from the second
`dropDuplicates`
+ CheckLastBatch(),
+ assertNumStateRows(total = Seq(1L, 2L), updated = Seq(0L, 1L)),
+
+ AddData(inputData, "b" -> 1),
+ CheckLastBatch("b" -> 1),
+ assertNumStateRows(total = Seq(2L, 3L), updated = Seq(1L, 1L))
+ )
+ }
+
+ test("deduplication with watermark") {
+ val inputData = MemoryStream[Int]
+ val result = inputData.toDS()
+ .withColumn("eventTime", $"value".cast("timestamp"))
+ .withWatermark("eventTime", "10 seconds")
+ .dropDuplicates()
+ .select($"eventTime".cast("long").as[Long])
+
+ testStream(result, Append)(
+ AddData(inputData, (1 to 5).flatMap(_ => (10 to 15)): _*),
+ CheckLastBatch(10 to 15: _*),
+ assertNumStateRows(total = 6, updated = 6),
+
+ AddData(inputData, 25), // Advance watermark to 15 seconds
+ CheckLastBatch(25),
+ assertNumStateRows(total = 7, updated = 1),
+
+ AddData(inputData, 25), // Drop states less than watermark
+ CheckLastBatch(),
+ assertNumStateRows(total = 1, updated = 0),
+
+ AddData(inputData, 10), // Should not emit anything as data less
than watermark
+ CheckLastBatch(),
+ assertNumStateRows(total = 1, updated = 0),
+
+ AddData(inputData, 45), // Advance watermark to 35 seconds
+ CheckLastBatch(45),
+ assertNumStateRows(total = 2, updated = 1),
+
+ AddData(inputData, 45), // Drop states less than watermark
+ CheckLastBatch(),
+ assertNumStateRows(total = 1, updated = 0)
+ )
+ }
+
+ test("deduplication with aggregation - append") {
+ val inputData = MemoryStream[Int]
+ val windowedAggregation = inputData.toDS()
+ .withColumn("eventTime", $"value".cast("timestamp"))
+ .withWatermark("eventTime", "10 seconds")
+ .dropDuplicates()
+ .withWatermark("eventTime", "10 seconds")
+ .groupBy(window($"eventTime", "5 seconds") as 'window)
+ .agg(count("*") as 'count)
+ .select($"window".getField("start").cast("long").as[Long],
$"count".as[Long])
+
+ testStream(windowedAggregation)(
+ AddData(inputData, (1 to 5).flatMap(_ => (10 to 15)): _*),
+ CheckLastBatch(),
+ // states in aggregation in [10, 14), [15, 20) (2 windows)
+ // states in deduplication is 10 to 15
+ assertNumStateRows(total = Seq(2L, 6L), updated = Seq(2L, 6L)),
+
+ AddData(inputData, 25), // Advance watermark to 15 seconds
+ CheckLastBatch(),
+ // states in aggregation in [10, 14), [15, 20) and [25, 30) (3
windows)
+ // states in deduplication is 10 to 15 and 25
+ assertNumStateRows(total = Seq(3L, 7L), updated = Seq(1L, 1L)),
+
+ AddData(inputData, 25), // Emit items less than watermark and drop
their state
+ CheckLastBatch((10 -> 5)), // 5 items (10 to 14) after deduplication
+ // states in aggregation in [15, 20) and [25, 30) (2 windows, note
aggregation uses the end of
+ // window to evict items, so [15, 20) is still in the state store)
+ // states in deduplication is 25
+ assertNumStateRows(total = Seq(2L, 1L), updated = Seq(0L, 0L)),
+
+ AddData(inputData, 10), // Should not emit anything as data less
than watermark
+ CheckLastBatch(),
+ assertNumStateRows(total = Seq(2L, 1L), updated = Seq(0L, 0L)),
+
+ AddData(inputData, 40), // Advance watermark to 30 seconds
+ CheckLastBatch(),
+ // states in aggregation in [15, 20), [25, 30) and [40, 45)
+ // states in deduplication is 25 and 40,
+ assertNumStateRows(total = Seq(3L, 2L), updated = Seq(1L, 1L)),
+
+ AddData(inputData, 40), // Emit items less than watermark and drop
their state
+ CheckLastBatch((15 -> 1), (25 -> 1)),
+ // states in aggregation in [40, 45)
+ // states in deduplication is 40,
+ assertNumStateRows(total = Seq(1L, 1L), updated = Seq(0L, 0L))
+ )
+ }
+
+ test("deduplication with aggregation - update") {
--- End diff --
nit: update mode
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
