Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16981#discussion_r101891903
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonUtils.scala
---
@@ -55,4 +62,32 @@ object JacksonUtils {
schema.foreach(field => verifyType(field.name, field.dataType))
}
+
+ private def validateStringLiteral(exp: Expression): String = exp match {
+ case Literal(s, StringType) => s.toString
+ case e => throw new AnalysisException("Must be a string literal, but:
" + e)
+ }
+
+ def validateSchemaLiteral(exp: Expression): StructType =
+ DataType.fromJson(validateStringLiteral(exp)).asInstanceOf[StructType]
+
+ /**
+ * Convert a literal including a json option string (e.g., '{"mode":
"PERMISSIVE", ...}')
+ * to Map-type data.
+ */
+ def validateOptionsLiteral(exp: Expression): Map[String, String] = {
+ val json = validateStringLiteral(exp)
+ parse(json) match {
+ case JObject(options) =>
--- End diff --
We could try to utilize `val parse(json).extract[Map[String, String]]`.
Given my observation, it produces empty `Map` if there are no such values or
empty json and it throws an exception if it is an invalid json.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
