Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16171#discussion_r101896246
  
    --- Diff: python/pyspark/ml/wrapper.py ---
    @@ -20,12 +20,14 @@
     if sys.version >= '3':
         xrange = range
     
    +from pyspark import since, keyword_only
     from pyspark import SparkContext
     from pyspark.sql import DataFrame
     from pyspark.ml import Estimator, Transformer, Model
     from pyspark.ml.param import Params
     from pyspark.ml.util import _jvm
     from pyspark.ml.common import inherit_doc, _java2py, _py2java
    +from pyspark.ml.param.shared import *
    --- End diff --
    
    Could we avoid an wild card import if it does not require many if more 
commits should be pushed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to