Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16626#discussion_r101960398 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -504,15 +504,15 @@ private[spark] class HiveExternalCatalog(conf: SparkConf, hadoopConf: Configurat * Note: As of now, this doesn't support altering table schema, partition column names and bucket * specification. We will ignore them even if users do specify different values for these fields. */ - override def alterTable(tableDefinition: CatalogTable): Unit = withClient { - assert(tableDefinition.identifier.database.isDefined) - val db = tableDefinition.identifier.database.get - requireTableExists(db, tableDefinition.identifier.table) - verifyTableProperties(tableDefinition) + override def alterTable(newTableDefinition: CatalogTable): Unit = withClient { + assert(newTableDefinition.identifier.database.isDefined) + val db = newTableDefinition.identifier.database.get + requireTableExists(db, newTableDefinition.identifier.table) + verifyTableProperties(newTableDefinition) // convert table statistics to properties so that we can persist them through hive api - val withStatsProps = if (tableDefinition.stats.isDefined) { - val stats = tableDefinition.stats.get + val maybeWithStatsPropsTable: CatalogTable = if (newTableDefinition.stats.isDefined) { --- End diff -- `: CatalogTable ` is not needed.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org