Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16985#discussion_r101973786
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -33,8 +33,8 @@ import org.apache.spark.util.collection.BitSet
* Performs a sort merge join of two child relations.
*/
case class SortMergeJoinExec(
- leftKeys: Seq[Expression],
- rightKeys: Seq[Expression],
+ var leftKeys: Seq[Expression],
--- End diff --
What information are you missing? The SortMergeExec is replaced after each
planning iteration.
I would prefer that we use a `lazy val` here instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
