Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/17014#discussion_r102262826
--- Diff: mllib/src/main/scala/org/apache/spark/ml/Predictor.scala ---
@@ -126,9 +129,10 @@ abstract class Predictor[
* and copying parameters into the model.
*
* @param dataset Training dataset
+ * @param handlePersistence Whether to persist the dataset in
implementation
* @return Fitted model
*/
- protected def train(dataset: Dataset[_]): M
+ protected def train(dataset: Dataset[_], handlePersistence: Boolean): M
--- End diff --
It's better if we can find a way not to break the API. We can give it some
time to see if there's better solution. Also if we have to, can we have some
default value for the new parameter?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
