Github user brkyvz commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16744#discussion_r102339985
  
    --- Diff: 
external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala
 ---
    @@ -341,6 +601,127 @@ object KinesisUtils {
        *                            details on the different types of 
checkpoints.
        * @param storageLevel Storage level to use for storing the received 
objects.
        *                     StorageLevel.MEMORY_AND_DISK_2 is recommended.
    +   * @param messageHandler A custom message handler that can generate a 
generic output from a
    +   *                       Kinesis `Record`, which contains both message 
data, and metadata.
    +   * @param recordClass Class of the records in DStream
    +   * @param stsAssumeRoleArn ARN of IAM role to assume when using STS 
sessions to read from
    +   *                         Kinesis stream.
    +   * @param stsSessionName Name to uniquely identify STS sessions if 
multiple princples assume
    +   *                       the same role.
    +   * @param stsExternalId External ID that can be used to validate against 
the assumed IAM role's
    +   *                      trust policy.
    +   *
    +   * @note The AWS credentials will be discovered using the 
DefaultAWSCredentialsProviderChain
    +   * on the workers. See AWS documentation to understand how 
DefaultAWSCredentialsProviderChain
    +   * gets the AWS credentials.
    +   */
    +  // scalastyle:off
    +  def createStream[T](
    --- End diff --
    
    let's remove this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to