Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16979#discussion_r102371334
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala
---
@@ -63,8 +63,34 @@ class HDFSMetadataLog[T <: AnyRef :
ClassTag](sparkSession: SparkSession, path:
val metadataPath = new Path(path)
protected val fileManager = createFileManager()
- if (!fileManager.exists(metadataPath)) {
- fileManager.mkdirs(metadataPath)
+ runUninterruptiblyIfLocal {
+ if (!fileManager.exists(metadataPath)) {
+ fileManager.mkdirs(metadataPath)
+ }
+ }
+
+ private def runUninterruptiblyIfLocal[T](body: => T): T = {
+ if (fileManager.isLocalFileSystem &&
Thread.currentThread.isInstanceOf[UninterruptibleThread]) {
--- End diff --
So we are changing this to a best-effort attempt, rather than the
try-and-explicitly-fail attempt, in the case of a local file system... right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
